git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] gitweb: make logo optional

From
Jakub Narebski <jnareb@gmail.com>
Date
Jan 4, 2011, 11:52 UTC
Message-ID
<201101041252.40254.jnareb@gmail.com>
In-Reply-To
<20110104050555.GC8280@burratino>
On Tue, 4 Dec 2011, Jonathan Nieder wrote:
> Some sites may not want to have a logo at all.  In particular, git
> instaweb can benefit from this.

Why do you think that git-instaweb can benefit from not having logo? You need gitweb.css anyway, so it is not much more trouble to serve additional static file, git-logo.png.

> 
> While at it, use $cgi->img to simplify this code.  (CGI.pm learned
> most HTML4 tags by version 2.79, so this should be portable to perl
> 5.8, though I haven't tested.)

corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81; IIRC gitweb requires something later than 5.8.0 for good support of Unicode (Encode module).

> 
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
For what it is worth it:
Acked-by: Jakub Narebski <jnareb@gmail.com>
-- 
Jakub Narebski
Poland
Previous: Jonathan NiederNext: Jonathan Nieder
Message 6 of 8 in “gitweb: make logo optional”
  1. 0/2 gitweb: make logo optionalJonathan Nieder, Jan 4, 2011
  2. 1/2 gitweb: skip logo in atom feed when there is noneJonathan Nieder, Jan 4, 2011
  3. Jakub NarebskiJan 5, 2011
  4. Junio C HamanoJan 5, 2011
  5. 2/2 gitweb: make logo optionalJonathan Nieder, Jan 4, 2011
  6. Jakub NarebskiJan 4, 2011
  7. Jonathan NiederJan 4, 2011
  8. Eric WongJan 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.