From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 04 Jan 2011 11:52:39 GMT
Subject: Re: [PATCH 2/2] gitweb: make logo optional
Message-ID: <201101041252.40254.jnareb@gmail.com>
In-Reply-To: <20110104050555.GC8280@burratino>

On Tue, 4 Dec 2011, Jonathan Nieder wrote:

> Some sites may not want to have a logo at all.  In particular, git
> instaweb can benefit from this.

Why do you think that git-instaweb can benefit from not having logo?
You need gitweb.css anyway, so it is not much more trouble to serve
additional static file, git-logo.png.

> 
> While at it, use $cgi->img to simplify this code.  (CGI.pm learned
> most HTML4 tags by version 2.79, so this should be portable to perl
> 5.8, though I haven't tested.)

corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81;
IIRC gitweb requires something later than 5.8.0 for good support of
Unicode (Encode module).

> 
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

For what it is worth it:

Acked-by: Jakub Narebski <jnareb@gmail.com>

-- 
Jakub Narebski
Poland