Re: [PATCH 2/2] gitweb: make logo optional

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 4, 2011, 16:29 UTC
Message-ID: <20110104162918.GA30141@burratino>
In-Reply-To: <201101041252.40254.jnareb@gmail.com>

Jakub Narebski wrote:

> On Tue, 4 Dec 2011, Jonathan Nieder wrote:

Show 6 quoted lines

>> Some sites may not want to have a logo at all.  In particular, git
>> instaweb can benefit from this.
>
> Why do you think that git-instaweb can benefit from not having logo?
> You need gitweb.css anyway, so it is not much more trouble to serve
> additional static file, git-logo.png.

Yep, that sentence is stale (it only applied in 1.7.1.x days) and should have been removed.

Show 10 quoted lines

> corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81;
> IIRC gitweb requires something later than 5.8.0 for good support of
> Unicode (Encode module).
>
>>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>
> For what it is worth it:
>
> Acked-by: Jakub Narebski <jnareb@gmail.com>

Thanks for looking it over.