git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] gitweb: skip logo in atom feed when there is none

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 4, 2011, 05:02 UTC
Message-ID
<20110104050247.GB8280@burratino>
In-Reply-To
<20110104050206.GA8280@burratino>
Date: Fri, 3 Sep 2010 19:44:39 -0500

With v1.5.0-rc0~169 (gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url, 2006-12-04), the logo URI to be written to Atom feeds was corrected but the case of no logo forgotten.

Acked-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4779618..c65af1a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7169,7 +7169,7 @@ XML
 		if (defined $favicon) {
 			print "<icon>" . esc_url($favicon) . "</icon>\n";
 		}
-		if (defined $logo_url) {
+		if (defined $logo) {
 			# not twice as wide as tall: 72 x 27 pixels
 			print "<logo>" . esc_url($logo) . "</logo>\n";
 		}
-- 
1.7.4.rc0
Previous: Jonathan NiederNext: Jakub Narebski
Message 2 of 8 in “gitweb: make logo optional”
  1. 0/2 gitweb: make logo optionalJonathan Nieder, Jan 4, 2011
  2. 1/2 gitweb: skip logo in atom feed when there is noneJonathan Nieder, Jan 4, 2011
  3. Jakub NarebskiJan 5, 2011
  4. Junio C HamanoJan 5, 2011
  5. 2/2 gitweb: make logo optionalJonathan Nieder, Jan 4, 2011
  6. Jakub NarebskiJan 4, 2011
  7. Jonathan NiederJan 4, 2011
  8. Eric WongJan 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.