Re: [PATCH v2 0/4] make open/unlink failures user friendly on windows using retry/abort

From: Johannes Sixt <j6t@kdbg.org>
Date: Nov 7, 2010, 15:49 UTC
Message-ID: <201011071649.20617.j6t@kdbg.org>
In-Reply-To: <cover.1289139299.git.hvoigt@hvoigt.net>

On Sonntag, 7. November 2010, Heiko Voigt wrote:

> j6t: I have not changed your error code in mingw_rename since you
> explicitely compare with the windows error code ERROR_ACCESS_DENIED and
> do not use the err_win_to_posix() function. Did you do this on purpose or
> should I also refer to ERROR_SHARING_VIOLATION ?

IIRC, I dumped the error code before I implemented the retry logic, and the error was ERROR_ACCESS_DENIED. Did you verify that the occasions where you want to retry the operations indeed fail due to ERROR_SHARING_VIOLATION, or do you trust the documentation?

In any case, it is better to check for the Windows error code (which ever you finally choose) rather than errno, IMO.

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.