Re: Pull request for msysGit patches
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 28, 2010, 21:23 UTC
- Message-ID
- <AANLkTinpSwuhT1_wtqNBeXLCud-F0bLBUgbohdtPp+8R@mail.gmail.com>
- In-Reply-To
- <7vocbhsn03.fsf@alter.siamese.dyndns.org>
On Tue, Sep 28, 2010 at 19:10, Junio C Hamano <gitster@pobox.com> wrote:
> git-send-email.perl > > Similar comment as is_absolute_path(), although in Perl environment I > suspect we can just use an existing package without adding our own.
It seems to me that the code added by Erik Faye-Lund in 33b2e81f84875bf515b4c0de830eeddfd04227dc and this new code in "send-email: handle Windows paths for display just like we do for processing" by bert could both be replaced by:
use File::Spec::Functions qw(file_name_is_absolute);
file_name_is_absolute($some_path);And by doing so we'd also be compatible with e.g. VMS. Can the people with the odd non-Unix systems maybe try this out and see if it works? :)