[PATCH v2 4/4] mingw: add fallback for rmdir in case directory is in use
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Nov 7, 2010, 14:56 UTC
- Message-ID
- <2497be75bac8877a06bef1d8c702f0c714fbc588.1289139299.git.hvoigt@hvoigt.net>
- In-Reply-To
- <cover.1289139299.git.hvoigt@hvoigt.net>
From: Heiko Voigt <heiko.voigt@mahr.de>
The same logic as for unlink and rename also applies to rmdir. For example in case you have a shell open in a git controlled folder. This will easily fail. So lets be nice for such cases as well.
Signed-off-by: Heiko Voigt <heiko.voigt@mahr.de> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net> --- compat/mingw.c | 25 +++++++++++++++++++++++++ compat/mingw.h | 3 +++ 2 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c index b66bf89..8e4f1e2 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -263,6 +263,31 @@ int mingw_unlink(const char *pathname) return ret; } +#undef rmdir +int mingw_rmdir(const char *pathname) +{ + int ret, tries = 0; + + while ((ret = rmdir(pathname)) == -1 && tries < ARRAY_SIZE(delay)) { + if (!is_file_in_use_error()) + break; + /* + * We assume that some other process had the source or + * destination file open at the wrong moment and retry. + * In order to give the other process a higher chance to + * complete its operation, we give up our time slice now. + * If we have to retry again, we do sleep a bit. + */ + Sleep(delay[tries]); + tries++; + } + while (ret == -1 && is_file_in_use_error() && + ask_user_yes_no("Deletion of directory '%s' failed. " + "Should I try again?", pathname)) + ret = rmdir(pathname); + return ret; +} + #undef open int mingw_open (const char *filename, int oflags, ...) { diff --git a/compat/mingw.h b/compat/mingw.h index 220ae90..cf69d39 100644 --- a/compat/mingw.h +++ b/compat/mingw.h @@ -172,6 +172,9 @@ int link(const char *oldpath, const char *newpath); int mingw_unlink(const char *pathname); #define unlink mingw_unlink +int mingw_rmdir(const char *path); +#define rmdir mingw_rmdir + int mingw_open (const char *filename, int oflags, ...); #define open mingw_open
-- 1.7.2.2.177.geec0d