From: Johannes Sixt Date: Sun, 07 Nov 2010 15:49:20 GMT Subject: Re: [PATCH v2 0/4] make open/unlink failures user friendly on windows using retry/abort Message-ID: <201011071649.20617.j6t@kdbg.org> In-Reply-To: On Sonntag, 7. November 2010, Heiko Voigt wrote: > j6t: I have not changed your error code in mingw_rename since you > explicitely compare with the windows error code ERROR_ACCESS_DENIED and > do not use the err_win_to_posix() function. Did you do this on purpose or > should I also refer to ERROR_SHARING_VIOLATION ? IIRC, I dumped the error code before I implemented the retry logic, and the error was ERROR_ACCESS_DENIED. Did you verify that the occasions where you want to retry the operations indeed fail due to ERROR_SHARING_VIOLATION, or do you trust the documentation? In any case, it is better to check for the Windows error code (which ever you finally choose) rather than errno, IMO. -- Hannes