git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks

From
Jeff King <peff@peff.net>
Date
Sep 21, 2010, 20:43 UTC
Message-ID
<20100921204312.GC395@sigill.intra.peff.net>
In-Reply-To
<vpqzkvaetq4.fsf@bauges.imag.fr>
On Tue, Sep 21, 2010 at 10:18:11PM +0200, Matthieu Moy wrote:
Show 7 quoted lines
> > This note clearly says "git diff is not affected, that's why we don't
> > write new tests for it".
> 
> I disagree with the implication. Git diff is not affected because it
> was done right, but behaving correctly doesn't mean you don't need
> tests. Checking the behavior of diff with tests wouldn't harm (but
> that's not serious not to do it).

Actually, there is some breakage in "git diff" with userdiffs, just not for textconv (but the fix covers both, so the problem is sort of a superset). I'm about to send a patch that has some tests, so don't worry about them for this series.

-Peff
Previous: Matthieu MoyNext: Kirill Smelkov
Message 7 of 9 in “Fix {blame,cat-file} --textconv for cases with symlinks”
  1. 0/3 Fix {blame,cat-file} --textconv for cases with symlinksKirill Smelkov, Sep 20, 2010
  2. 1/3 tests: Prepare --textconv tests for correctly-failing conversion programKirill Smelkov, Sep 20, 2010
  3. 2/3 blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinksKirill Smelkov, Sep 20, 2010
  4. Matthieu MoySep 20, 2010
  5. Kirill SmelkovSep 21, 2010
  6. Matthieu MoySep 21, 2010
  7. Jeff KingSep 21, 2010
  8. Kirill SmelkovSep 24, 2010
  9. 3/3 blame,cat-file --textconv: Don't assume mode is ``S_IFREF | 0664''Kirill Smelkov, Sep 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.