Re: [PATCH v2 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 21, 2010, 20:18 UTC
Message-ID: <vpqzkvaetq4.fsf@bauges.imag.fr>
In-Reply-To: <20100921183959.GB4390@landau.phys.spbu.ru>

Kirill Smelkov <kirr@landau.phys.spbu.ru> writes:

Show 8 quoted lines

> I know about --- and that content after it and up to patch itself goes
> to /dev/null. The text here was intended to stay in the commit message,
> and ~~~~ served as a separator in that message (git commit hook merges
> several blank lines into one, so one can't separate text parts with
> several empty lines, that's why I used this separator).
>
> If it's ugly, let's omit it - I don't insist, but i don't understand why
> 'NOTE:' looks odd?

That was especially about the combination of both, but I don't really care. Consider my remarks as food for thoughts, not real objections.

> This note clearly says "git diff is not affected, that's why we don't
> write new tests for it".

I disagree with the implication. Git diff is not affected because it was done right, but behaving correctly doesn't mean you don't need tests. Checking the behavior of diff with tests wouldn't harm (but that's not serious not to do it).

Show 5 quoted lines

>> Reviewed-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
>
> Thanks :)
>
> Is it for this one patch, or does it apply to the whole series?

To the serie, yes.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/