Re: [PATCH v2 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 20, 2010, 21:13 UTC
Message-ID: <vpqvd6086fq.fsf@bauges.imag.fr>
In-Reply-To: <3c344d9b8f014ccb96dc37dc42668426fb5a3c30.1285013802.git.kirr@landau.phys.spbu.ru>

Kirill Smelkov <kirr@landau.phys.spbu.ru> writes:

> (Description partly by Matthieu Moy)

Better put such statements at the end, to avoid distracting the reader.

> ~~~~
>
> NOTE: git diff doesn't try to textconv the pathnames, it runs the
> textual diff without textconv, which is the expected behavior.

It's not clear whether this is intended to stay in the commit message. If not, it should go below the ---. If yes, then I'd incorporate this into the message itself. The ~~~~ and NOTE look odd.

For example (in next patch):

| Instead get the mode from either worktree, index, .git, or origin
| entries when blaming and pass it to textconv_object() as context.
| 
| The reason to do it is not to run textconv filters on symlinks
+ (just like "git diff" already does).

Anyway, I'm bikeshedding. With or without these remarks,

Reviewed-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/