From: Jeff King <peff@peff.net>
Date: Tue, 21 Sep 2010 20:43:12 GMT
Subject: Re: [PATCH v2 2/3] blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks
Message-ID: <20100921204312.GC395@sigill.intra.peff.net>
In-Reply-To: <vpqzkvaetq4.fsf@bauges.imag.fr>

On Tue, Sep 21, 2010 at 10:18:11PM +0200, Matthieu Moy wrote:

> > This note clearly says "git diff is not affected, that's why we don't
> > write new tests for it".
> 
> I disagree with the implication. Git diff is not affected because it
> was done right, but behaving correctly doesn't mean you don't need
> tests. Checking the behavior of diff with tests wouldn't harm (but
> that's not serious not to do it).

Actually, there is some breakage in "git diff" with userdiffs, just not
for textconv (but the fix covers both, so the problem is sort of a
superset).  I'm about to send a patch that has some tests, so don't
worry about them for this series.

-Peff