git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/4] Support for running tests outside t/ + don't run a TODO test

From
Jeff King <peff@peff.net>
Date
Aug 19, 2010, 16:18 UTC
Message-ID
<20100819161821.GA27381@sigill.intra.peff.net>
In-Reply-To
<1282234092-27429-1-git-send-email-avarab@gmail.com>
On Thu, Aug 19, 2010 at 04:08:08PM +0000, Ævar Arnfjörð Bjarmason wrote:
Show 5 quoted lines
> As an aside there's a bunch of other things in our tests that are
> writing out shellscripts with a #!/bin/sh shebang instead of
> #!$SHELL_PATH. These are passing purely by accident since they just
> happen to use shell syntax that doesn't run afoul of grumpy old shells
> like Solaris's /bin/sh.

It's not an accident. I (and others) checked them all when $SHELL_PATH became available to the test scripts, and declared them all trivial. But I would not be opposed to making them all #!$SHELL_PATH.

-Peff
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 11 of 20 in “t/t0000-basic.sh: Don't run a passing TODO unless TEST_PASSING_TODO=1”
  1. t/t0000-basic.sh: Don't run a passing TODO unless TEST_PASSING_TODO=1Ævar Arnfjörð Bjarmason, Aug 17, 2010
  2. Sverre RabbelierAug 17, 2010
  3. Junio C HamanoAug 17, 2010
  4. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 18, 2010
  5. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 19, 2010
  6. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  7. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  8. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 19, 2010
  9. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 19, 2010
  10. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 19, 2010
  11. Jeff KingAug 19, 2010
  12. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  13. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  14. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 19, 2010
  15. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 19, 2010
  16. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 18, 2010
  17. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 18, 2010
  18. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 18, 2010
  19. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 18, 2010
  20. Sverre RabbelierAug 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.