git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/4] test-lib: Allow overriding of TEST_DIRECTORY

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 19, 2010, 16:06 UTC
Message-ID
<1282233961-27203-4-git-send-email-avarab@gmail.com>
In-Reply-To
<1282138473-15613-1-git-send-email-avarab@gmail.com>

Tests that test the test-lib.sh itself need to be executed in the dynamically created trash directory, so we can't assume $TEST_DIRECTORY is ../ for those.

As a side benefit this change also makes it easy for us to move the t/*.sh tests into subdirectories if we ever want to do that.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/test-lib.sh |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 689aa29..01ddf3e 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -747,7 +747,13 @@ test_done () {
 
 # Test the binaries we have just built.  The tests are kept in
 # t/ subdirectory and are run in 'trash directory' subdirectory.
-TEST_DIRECTORY=$(pwd)
+if test -z "$TEST_DIRECTORY"
+then
+	# We allow tests to override this, in case they want to run tests
+	# outside of t/, e.g. for running tests on the test library
+	# itself.
+	TEST_DIRECTORY=$(pwd)
+fi
 GIT_BUILD_DIR="$TEST_DIRECTORY"/..
 
 if test -n "$valgrind"
-- 
1.7.2.1.414.g9bf49
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 8 of 20 in “t/t0000-basic.sh: Don't run a passing TODO unless TEST_PASSING_TODO=1”
  1. t/t0000-basic.sh: Don't run a passing TODO unless TEST_PASSING_TODO=1Ævar Arnfjörð Bjarmason, Aug 17, 2010
  2. Sverre RabbelierAug 17, 2010
  3. Junio C HamanoAug 17, 2010
  4. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 18, 2010
  5. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 19, 2010
  6. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  7. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  8. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 19, 2010
  9. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 19, 2010
  10. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 19, 2010
  11. Jeff KingAug 19, 2010
  12. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  13. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  14. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 19, 2010
  15. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 19, 2010
  16. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 18, 2010
  17. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 18, 2010
  18. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 18, 2010
  19. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 18, 2010
  20. Sverre RabbelierAug 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.