From: Jeff King Date: Thu, 19 Aug 2010 16:18:21 GMT Subject: Re: [PATCH v3 0/4] Support for running tests outside t/ + don't run a TODO test Message-ID: <20100819161821.GA27381@sigill.intra.peff.net> In-Reply-To: <1282234092-27429-1-git-send-email-avarab@gmail.com> On Thu, Aug 19, 2010 at 04:08:08PM +0000, Ævar Arnfjörð Bjarmason wrote: > As an aside there's a bunch of other things in our tests that are > writing out shellscripts with a #!/bin/sh shebang instead of > #!$SHELL_PATH. These are passing purely by accident since they just > happen to use shell syntax that doesn't run afoul of grumpy old shells > like Solaris's /bin/sh. It's not an accident. I (and others) checked them all when $SHELL_PATH became available to the test scripts, and declared them all trivial. But I would not be opposed to making them all #!$SHELL_PATH. -Peff