git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 4/4] t/t0000-basic.sh: Run the passing TODO test inside its own test-lib

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Aug 19, 2010, 17:39 UTC
Message-ID
<AANLkTin5XciuPCusghw4GihsYp2Lq8Ng1UcWACRrDy6f@mail.gmail.com>
In-Reply-To
<1282138473-15613-5-git-send-email-avarab@gmail.com>
Heya,
On Wed, Aug 18, 2010 at 08:34, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> Change the passing TODO test in t0000-basic.sh to run inside its own
> test-lib.sh. The motivation is to have nothing out of the ordinary on
> a normal test run for test smoking purposes.

I like the effect of this patch, but the patch itself is a bit obscure perhaps. I'll defer judgement on whether this is acceptable to others :).

-- 
Cheers,

Sverre Rabbelier
Previous: Ævar Arnfjörð Bjarmason
Message 20 of 20 in “t/t0000-basic.sh: Don't run a passing TODO unless TEST_PASSING_TODO=1”
  1. t/t0000-basic.sh: Don't run a passing TODO unless TEST_PASSING_TODO=1Ævar Arnfjörð Bjarmason, Aug 17, 2010
  2. Sverre RabbelierAug 17, 2010
  3. Junio C HamanoAug 17, 2010
  4. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 18, 2010
  5. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 19, 2010
  6. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  7. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  8. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 19, 2010
  9. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 19, 2010
  10. 0/4 Support for running tests outside t/ + don't run a TODO testÆvar Arnfjörð Bjarmason, Aug 19, 2010
  11. Jeff KingAug 19, 2010
  12. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  13. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 19, 2010
  14. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 19, 2010
  15. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 19, 2010
  16. 1/4 test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../Ævar Arnfjörð Bjarmason, Aug 18, 2010
  17. 2/4 test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../Ævar Arnfjörð Bjarmason, Aug 18, 2010
  18. 3/4 test-lib: Allow overriding of TEST_DIRECTORYÆvar Arnfjörð Bjarmason, Aug 18, 2010
  19. 4/4 t/t0000-basic.sh: Run the passing TODO test inside its own test-libÆvar Arnfjörð Bjarmason, Aug 18, 2010
  20. Sverre RabbelierAug 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.