git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/7] revert: refactor code to find commit subject in find_commit_subject()

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jul 23, 2010, 09:37 UTC
Message-ID
<201007231138.00360.chriscool@tuxfamily.org>
In-Reply-To
<20100722165012.GA4938@m62s10.vlinux.de>
On Thursday 22 July 2010 18:50:12 Peter Baumann wrote:
> Wouldn't it be better to merge this with  [PATCH 4/7], so we won't create
> find_commit_subject in revert.c and then immediatly move it to commit.c?

Yeah, I could have merged those 2 patches, but except for the first one I developed them in the order I sent them. So I didn't think much about merging some as it felt natural to send them as is.

Best regards, Christian.

Previous: Peter BaumannNext: Christian Couder
Message 6 of 12 in “find commit subject refactoring”
  1. 0/7 find commit subject refactoringChristian Couder, Jul 22, 2010
  2. 1/7 revert: fix off by one read when searching the end of a commit subjectChristian Couder, Jul 22, 2010
  3. Jonathan NiederJul 22, 2010
  4. 2/7 revert: refactor code to find commit subject in find_commit_subject()Christian Couder, Jul 22, 2010
  5. Peter BaumannJul 22, 2010
  6. Christian CouderJul 23, 2010
  7. 3/7 revert: rename subject related variables in get_message()Christian Couder, Jul 22, 2010
  8. 4/7 commit: move find_commit_subject() into commit.{h,c}Christian Couder, Jul 22, 2010
  9. 5/7 bisect: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  10. 6/7 merge-recursive: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  11. 7/7 blame: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  12. Junio C HamanoJul 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.