git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] merge-recursive: use find_commit_subject() instead of custom code

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jul 22, 2010, 13:18 UTC
Message-ID
<20100722131836.2148.12472.chriscool@tuxfamily.org>
In-Reply-To
<20100722131141.2148.63850.chriscool@tuxfamily.org>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 merge-recursive.c |   14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/merge-recursive.c b/merge-recursive.c
index 529d345..08f666a 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -136,16 +136,10 @@ static void output_commit_title(struct merge_options *o, struct commit *commit)
 		if (parse_commit(commit) != 0)
 			printf("(bad commit)\n");
 		else {
-			const char *s;
-			int len;
-			for (s = commit->buffer; *s; s++)
-				if (*s == '\n' && s[1] == '\n') {
-					s += 2;
-					break;
-				}
-			for (len = 0; s[len] && '\n' != s[len]; len++)
-				; /* do nothing */
-			printf("%.*s\n", len, s);
+			const char *title;
+			int len = find_commit_subject(commit->buffer, &title);
+			if (len)
+				printf("%.*s\n", len, title);
 		}
 	}
 }
-- 
1.7.2.rc3.267.g400b3
Previous: Christian CouderNext: Christian Couder
Message 10 of 12 in “find commit subject refactoring”
  1. 0/7 find commit subject refactoringChristian Couder, Jul 22, 2010
  2. 1/7 revert: fix off by one read when searching the end of a commit subjectChristian Couder, Jul 22, 2010
  3. Jonathan NiederJul 22, 2010
  4. 2/7 revert: refactor code to find commit subject in find_commit_subject()Christian Couder, Jul 22, 2010
  5. Peter BaumannJul 22, 2010
  6. Christian CouderJul 23, 2010
  7. 3/7 revert: rename subject related variables in get_message()Christian Couder, Jul 22, 2010
  8. 4/7 commit: move find_commit_subject() into commit.{h,c}Christian Couder, Jul 22, 2010
  9. 5/7 bisect: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  10. 6/7 merge-recursive: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  11. 7/7 blame: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  12. Junio C HamanoJul 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.