Re: [PATCH 1/7] revert: fix off by one read when searching the end of a commit subject

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 22, 2010, 23:00 UTC
Message-ID: <20100722230000.GD19745@burratino>
In-Reply-To: <20100722131836.2148.57468.chriscool@tuxfamily.org>

Christian Couder wrote:

Show 10 quoted lines

> +++ b/builtin/revert.c
> @@ -131,7 +131,7 @@ static int get_message(const char *raw_message, struct commit_message *out)
>  		p++;
>  	if (*p) {
>  		p += 2;
> -		for (eol = p + 1; *eol && *eol != '\n'; eol++)
> +		for (eol = p; *eol && *eol != '\n'; eol++)
>  			; /* do nothing */
>  	} else
>  		eol = p;

Good catch.  For what it’s worth, this and the rest of the series is

Acked-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.