git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] bisect: use find_commit_subject() instead of custom code

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jul 22, 2010, 13:18 UTC
Message-ID
<20100722131836.2148.55405.chriscool@tuxfamily.org>
In-Reply-To
<20100722131141.2148.63850.chriscool@tuxfamily.org>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 bisect.c |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/bisect.c b/bisect.c
index b556b11..060c042 100644
--- a/bisect.c
+++ b/bisect.c
@@ -141,7 +141,8 @@ static void show_list(const char *debug, int counted, int nr,
 		enum object_type type;
 		unsigned long size;
 		char *buf = read_sha1_file(commit->object.sha1, &type, &size);
-		char *ep, *sp;
+		const char *subject_start;
+		int subject_len;
 
 		fprintf(stderr, "%c%c%c ",
 			(flags & TREESAME) ? ' ' : 'T',
@@ -156,13 +157,9 @@ static void show_list(const char *debug, int counted, int nr,
 			fprintf(stderr, " %.*s", 8,
 				sha1_to_hex(pp->item->object.sha1));
 
-		sp = strstr(buf, "\n\n");
-		if (sp) {
-			sp += 2;
-			for (ep = sp; *ep && *ep != '\n'; ep++)
-				;
-			fprintf(stderr, " %.*s", (int)(ep - sp), sp);
-		}
+		subject_len = find_commit_subject(buf, &subject_start);
+		if (subject_len)
+			fprintf(stderr, " %.*s", subject_len, subject_start);
 		fprintf(stderr, "\n");
 	}
 }
-- 
1.7.2.rc3.267.g400b3
Previous: Christian CouderNext: Christian Couder
Message 9 of 12 in “find commit subject refactoring”
  1. 0/7 find commit subject refactoringChristian Couder, Jul 22, 2010
  2. 1/7 revert: fix off by one read when searching the end of a commit subjectChristian Couder, Jul 22, 2010
  3. Jonathan NiederJul 22, 2010
  4. 2/7 revert: refactor code to find commit subject in find_commit_subject()Christian Couder, Jul 22, 2010
  5. Peter BaumannJul 22, 2010
  6. Christian CouderJul 23, 2010
  7. 3/7 revert: rename subject related variables in get_message()Christian Couder, Jul 22, 2010
  8. 4/7 commit: move find_commit_subject() into commit.{h,c}Christian Couder, Jul 22, 2010
  9. 5/7 bisect: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  10. 6/7 merge-recursive: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  11. 7/7 blame: use find_commit_subject() instead of custom codeChristian Couder, Jul 22, 2010
  12. Junio C HamanoJul 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.