From: Jeff King <peff@peff.net>
Date: Tue, 25 May 2010 09:23:36 GMT
Subject: Re: [PATCH 0/6 rebase-version] Make git log --graph looks better with -p and other diff options
Message-ID: <20100525092336.GB30863@coredump.intra.peff.net>
In-Reply-To: <1274778154-29976-1-git-send-email-struggleyb.nku@gmail.com>

On Tue, May 25, 2010 at 05:02:28PM +0800, Bo Yang wrote:

> From: byang <byang@byang-laptop.(none)>
> 
> Rebase for a new master...
> 
> Bo Yang (6):
>   Add a prefix output callback to diff output.
>   Output the graph columns at the end of the commit message.
>   diff.c: Output the text graph padding before each diff line.

These patches look fine to me.

>   Emit a whole line once a time.

I have to admit I don't quite understand from the commit message what
the problem is that this is fixing.

>   Register a callback for graph output.

This one looks fine.

>   Make --color-words work well with --graph.

Your explanation of the rules for when to output sounds sensible to me,
but I'm not familiar enough with the color-words code to evaluate it
(and I lack the time and sleep to look at it more carefully tonight).

-Peff