git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9302: Protect against OS X normalization

From
Jeff King <peff@peff.net>
Date
Feb 9, 2010, 06:58 UTC
Message-ID
<20100209065845.GA6503@sigill.intra.peff.net>
In-Reply-To
<7vocjyq4qq.fsf@alter.siamese.dyndns.org>
On Mon, Feb 08, 2010 at 10:53:49PM -0800, Junio C Hamano wrote:
Show 5 quoted lines
> I think there is no reliable reproduction recipe for this, as we don't
> control what garbage is in the tail of malloc'ed memory; valgrind would
> have found it, though.
>
> Let's revert the test part of the patch.

IMHO, valgrind finding it is reason enough to keep it. We do run the test suite against valgrind from time to time, and clearly this code path was not being exercised prior to this (or my previous valgrind runs would have caught it).

I think Brian's patch is the best thing to do.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “OS X Unicode Normalization Hits Again”
  1. Brian GernhardtFeb 9, 2010
  2. Junio C HamanoFeb 9, 2010
  3. t9302: Protect against OS X normalizationBrian Gernhardt, Feb 9, 2010
  4. Jeff KingFeb 9, 2010
  5. Jeff KingFeb 9, 2010
  6. Junio C HamanoFeb 9, 2010
  7. Jeff KingFeb 9, 2010
  8. Junio C HamanoFeb 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.