From: Jeff King <peff@peff.net>
Date: Tue, 09 Feb 2010 06:58:45 GMT
Subject: Re: [PATCH] t9302: Protect against OS X normalization
Message-ID: <20100209065845.GA6503@sigill.intra.peff.net>
In-Reply-To: <7vocjyq4qq.fsf@alter.siamese.dyndns.org>

On Mon, Feb 08, 2010 at 10:53:49PM -0800, Junio C Hamano wrote:

> I think there is no reliable reproduction recipe for this, as we don't
> control what garbage is in the tail of malloc'ed memory; valgrind would
> have found it, though.
>
> Let's revert the test part of the patch.

IMHO, valgrind finding it is reason enough to keep it. We do run the
test suite against valgrind from time to time, and clearly this code
path was not being exercised prior to this (or my previous valgrind runs
would have caught it).

I think Brian's patch is the best thing to do.

-Peff