Re: [PATCH] t9302: Protect against OS X normalization

From: Jeff King <peff@peff.net>
Date: Feb 9, 2010, 06:08 UTC
Message-ID: <20100209060845.GD14736@coredump.intra.peff.net>
In-Reply-To: <1265688445-46137-1-git-send-email-brian@gernhardtsoftware.com>

On Mon, Feb 08, 2010 at 11:07:25PM -0500, Brian Gernhardt wrote:

Show 16 quoted lines

> 8424981: "Fix invalid read in quote_c_style_counted" introduced a test
> that used "caractère spécial" as a directory name.
> 
> Git creates it as "caract\303\250re sp\303\251cial"
> OS X stores it as "caracte\314\200re spe\314\201cial"
> 
> To work around this problem, use the already introduced $FN as the
> directory name.
> 
> Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
> ---
> 
>  Junio C Hamano wrote:
>  > How about using $FN as the directory name instead?
> 
>  I knew there was a clever answer I was missing.

I am not 100% sure this will still trigger the failure that 8424981 was meant to fix. From my recollection of the bug, it not only needed an unterminated string (which we get by having a directory) but the string length and presence of multiple spread-out characters may have been relevant.

Of course, that specific bug is fixed, so maybe it is not worth worrying about too much.

-Peff