Re: [PATCH] t9302: Protect against OS X normalization

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2010, 07:05 UTC
Message-ID: <7vr5ouopn4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100209065845.GA6503@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Mon, Feb 08, 2010 at 10:53:49PM -0800, Junio C Hamano wrote:
>
>> I think there is no reliable reproduction recipe for this, as we don't
>> control what garbage is in the tail of malloc'ed memory; valgrind would
>> have found it, though.
>>
>> Let's revert the test part of the patch.
>
> IMHO, valgrind finding it is reason enough to keep it. We do run the
> test suite against valgrind from time to time, and clearly this code
> path was not being exercised prior to this (or my previous valgrind runs
> would have caught it).
>
> I think Brian's patch is the best thing to do.

Having Brian's patch would not hurt, and it definitely is an improvement than using a name OSX cannot cope with, so I'll apply it nevertheless.

FWIW, neither the updated test nor your French test does not trigger for me after reverting the "quote.c" part from 8424981 without valgrind.

Thanks for helping me think this through.