git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] stash: reject stash name starting with a dash.

From
Jeff King <peff@peff.net>
Date
Aug 18, 2009, 23:54 UTC
Message-ID
<20090818235446.GA11153@sigill.intra.peff.net>
In-Reply-To
<7vocqc3cuz.fsf@alter.siamese.dyndns.org>
On Tue, Aug 18, 2009 at 04:45:40PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> > Should this actually be "git stash save --invalid-option", since it is
> > really testing the actual save option parsing, and not the behavior to
> > automatically push options to "git stash save"?
> 
> It would be ideal if
> 
> 	git stash save --invalid-option
> 
> failed, while
> 
> 	git stash --invalid-option should be trapped
> 
> and/or
> 
> 	git stash "--invalid-option should be trapped"
> 
> are accepted as valid quickie ways to name a WIP stash before attending to
> an unrelated emergency.

I thought that was the exact DWIM that was rejected previously so that you don't accidentally make commits with "git stash llist" or "git stash --almost-a-valid-optio".

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 22 in “stash: accept options also when subcommand 'save' is omitted”
  1. stash: accept options also when subcommand 'save' is omittedMatthieu Moy, Aug 18, 2009
  2. Matthieu MoyAug 18, 2009
  3. Jeff KingAug 18, 2009
  4. Junio C HamanoAug 18, 2009
  5. 0/3 short syntaxes for 'git stash'Matthieu Moy, Aug 18, 2009
  6. 1/3 stash: accept -k as a shortcut for --keep-indexMatthieu Moy, Aug 18, 2009
  7. 2/3 stash: accept options also when subcommand 'save' is omittedMatthieu Moy, Aug 18, 2009
  8. 3/3 stash: reject stash name starting with a dash.Matthieu Moy, Aug 18, 2009
  9. Jeff KingAug 18, 2009
  10. Junio C HamanoAug 18, 2009
  11. Jeff KingAug 18, 2009
  12. Junio C HamanoAug 18, 2009
  13. Matthieu MoyAug 19, 2009
  14. Jeff KingAug 19, 2009
  15. Jeff KingAug 18, 2009
  16. Johannes SchindelinAug 18, 2009
  17. Matthieu MoyAug 18, 2009
  18. Johannes SchindelinAug 18, 2009
  19. Matthieu MoyAug 19, 2009
  20. Jeff KingAug 18, 2009
  21. Johannes SchindelinAug 18, 2009
  22. Jeff KingAug 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.