From: Jeff King <peff@peff.net>
Date: Tue, 18 Aug 2009 23:54:46 GMT
Subject: Re: [PATCH 3/3] stash: reject stash name starting with a dash.
Message-ID: <20090818235446.GA11153@sigill.intra.peff.net>
In-Reply-To: <7vocqc3cuz.fsf@alter.siamese.dyndns.org>

On Tue, Aug 18, 2009 at 04:45:40PM -0700, Junio C Hamano wrote:

> > Should this actually be "git stash save --invalid-option", since it is
> > really testing the actual save option parsing, and not the behavior to
> > automatically push options to "git stash save"?
> 
> It would be ideal if
> 
> 	git stash save --invalid-option
> 
> failed, while
> 
> 	git stash --invalid-option should be trapped
> 
> and/or
> 
> 	git stash "--invalid-option should be trapped"
> 
> are accepted as valid quickie ways to name a WIP stash before attending to
> an unrelated emergency.

I thought that was the exact DWIM that was rejected previously so that
you don't accidentally make commits with "git stash llist" or "git stash
--almost-a-valid-optio".

-Peff