git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] stash: accept options also when subcommand 'save' is omitted

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 18, 2009, 22:37 UTC
Message-ID
<alpine.DEB.1.00.0908190035140.8306@pacific.mpi-cbg.de>
In-Reply-To
<vpqtz0423jk.fsf@bauges.imag.fr>
Hi,
On Tue, 18 Aug 2009, Matthieu Moy wrote:
Show 7 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > But it is sloppy, in that it blindly accepts options that might be 
> > valid for several subcommands, not just "save".
> 
> I wouldn't call that sloppy. 'save' is the default command, if you don't 
> provide any command, then 'save' will be used.

'save' might be the default command, but we don't trigger it with _any_ crap, for a very good reason. Read the commit log for git-stash.sh to know why.

Show 5 quoted lines
> > So please register my objection.
> 
> I will if you register my objection to yours ;-).
> 
> Jokes aside,

If you think that's funny, I don't. I actually put a lot of thought into the issue whether to allow _any_ parameter with looks like an option to trigger "save". And I very much had to come to the decision that no, that is too dangerous.

So I cannot take your objection seriously.

Ciao, Dscho

Previous: Matthieu MoyNext: Matthieu Moy
Message 18 of 22 in “stash: accept options also when subcommand 'save' is omitted”
  1. stash: accept options also when subcommand 'save' is omittedMatthieu Moy, Aug 18, 2009
  2. Matthieu MoyAug 18, 2009
  3. Jeff KingAug 18, 2009
  4. Junio C HamanoAug 18, 2009
  5. 0/3 short syntaxes for 'git stash'Matthieu Moy, Aug 18, 2009
  6. 1/3 stash: accept -k as a shortcut for --keep-indexMatthieu Moy, Aug 18, 2009
  7. 2/3 stash: accept options also when subcommand 'save' is omittedMatthieu Moy, Aug 18, 2009
  8. 3/3 stash: reject stash name starting with a dash.Matthieu Moy, Aug 18, 2009
  9. Jeff KingAug 18, 2009
  10. Junio C HamanoAug 18, 2009
  11. Jeff KingAug 18, 2009
  12. Junio C HamanoAug 18, 2009
  13. Matthieu MoyAug 19, 2009
  14. Jeff KingAug 19, 2009
  15. Jeff KingAug 18, 2009
  16. Johannes SchindelinAug 18, 2009
  17. Matthieu MoyAug 18, 2009
  18. Johannes SchindelinAug 18, 2009
  19. Matthieu MoyAug 19, 2009
  20. Jeff KingAug 18, 2009
  21. Johannes SchindelinAug 18, 2009
  22. Jeff KingAug 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.