Re: [RFC PATCH] stash: accept options also when subcommand 'save' is omitted

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

I wouldn't call that sloppy. 'save' is the default command, if you don't provide any command, then 'save' will be used.

So, "git stash -p" means "git stash save -p" regardless of the fact that there exists somewhere else a "git stash list -p". Actually, in the current form of pu, it is already the case since

f300fab (Thomas Rast, DWIM 'git stash save -p' for 'git stash -p')

which came right after your patch.

I will if you register my objection to yours ;-).

Jokes aside, if you insist in rejecting 'git stash -p', then my patch can be slightly modified to say something like

+case "$1" in
+    -k|--keep-index|--patch)
+       set "save" "$@"
+       ;;
+esac

instead, which also allows multiple arguments (unlike your initial proposal), and can control more precisely the list of options for which 'save' is a default.

-- Matthieu