git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RF sanity check] send-email threading fixes (was Re: [PATCH 3/6] send-email: fix threaded mails without chain-reply-to)

From
Markus Heidelberg <markus.heidelberg@web.de>
Date
Jun 11, 2009, 16:49 UTC
Message-ID
<200906111849.40232.markus.heidelberg@web.de>
In-Reply-To
<7v63f4v9sl.fsf@alter.siamese.dyndns.org>
Junio C Hamano, 10.06.2009:
Show 13 quoted lines
> In any case, here is what I came up with by reshuffling your six patches.
> 
> [PATCH 1/6] add a test for git-send-email for non-threaded mails
> [PATCH 2/6] send-email: fix non-threaded mails
> [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread
> [PATCH 4/6] send-email: fix threaded mails without chain-reply-to
> [PATCH 5/6] add a test for git-send-email for threaded mails without chain-reply-to
> [PATCH 6/6] send-email: fix a typo in a comment
> 
> Patch 4/6 applies on top of 15da108 to fix a breakage introduced by that
> commit.  Together with the result of applying the first three patches to
> maint, they fix --no-thread and --thread (without --chain-reply-to) cases.
> The result can be verified by applying Patch 5/6 on top of them.

Out of curiosity: why are 4/6 and 5/6 applied on different branches without the usual commits first "test with test_expect_fail" then "fix + test changed to test_expect_success"?

Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 38 in “fixes for git-send-email”
  1. 0/6 fixes for git-send-emailMarkus Heidelberg, Jun 7, 2009
  2. 1/6 send-email: fix a typo in a commentMarkus Heidelberg, Jun 7, 2009
  3. Junio C HamanoJun 8, 2009
  4. Markus HeidelbergJun 9, 2009
  5. 1/2 add a test for git-send-email for non-threaded mailsMarkus Heidelberg, Jun 9, 2009
  6. 2/2 send-email: fix non-threaded mailsMarkus Heidelberg, Jun 9, 2009
  7. 2/6 add a test for git-send-email for threaded mails without chain-reply-toMarkus Heidelberg, Jun 7, 2009
  8. Junio C HamanoJun 7, 2009
  9. Markus HeidelbergJun 8, 2009
  10. 2/6 add a test for git-send-email for threaded mails without chain-reply-toMarkus Heidelberg, Jun 8, 2009
  11. Junio C HamanoJun 8, 2009
  12. 3/6 send-email: fix threaded mails without chain-reply-toMarkus Heidelberg, Jun 7, 2009
  13. Junio C HamanoJun 10, 2009
  14. [RF sanity check] send-email threading fixes (was Re: [PATCH 3/6] send-email: fix threaded mails without chain-reply-to)Junio C Hamano, Jun 10, 2009
  15. Markus HeidelbergJun 11, 2009
  16. Junio C HamanoJun 11, 2009
  17. Markus HeidelbergJun 11, 2009
  18. Junio C HamanoJun 11, 2009
  19. 0/6 send-email threading fixesMarkus Heidelberg, Jun 12, 2009
  20. 1/6 add a test for git-send-email for non-threaded mailsMarkus Heidelberg, Jun 12, 2009
  21. 2/6 send-email: fix non-threaded mailsMarkus Heidelberg, Jun 12, 2009
  22. 3/6 doc/send-email: clarify the behavior of --in-reply-to with --no-threadMarkus Heidelberg, Jun 12, 2009
  23. 4/6 add a test for git-send-email for threaded mails without chain-reply-toMarkus Heidelberg, Jun 12, 2009
  24. 5/6 send-email: fix threaded mails without chain-reply-toMarkus Heidelberg, Jun 12, 2009
  25. 6/6 send-email: fix a typo in a commentMarkus Heidelberg, Jun 12, 2009
  26. 1/6 add a test for git-send-email for non-threaded mailsJunio C Hamano, Jun 10, 2009
  27. 2/6 send-email: fix non-threaded mailsJunio C Hamano, Jun 10, 2009
  28. 3/6 doc/send-email: clarify the behavior of --in-reply-to with --no-threadJunio C Hamano, Jun 10, 2009
  29. 4/6 send-email: fix threaded mails without chain-reply-toJunio C Hamano, Jun 10, 2009
  30. 5/6 add a test for git-send-email for threaded mails without chain-reply-toJunio C Hamano, Jun 10, 2009
  31. 6/6 send-email: fix a typo in a commentJunio C Hamano, Jun 10, 2009
  32. 4/6 add a test for git-send-email for non-threaded mailsMarkus Heidelberg, Jun 7, 2009
  33. Markus HeidelbergJun 8, 2009
  34. Junio C HamanoJun 8, 2009
  35. 4/6 add a test for git-send-email for non-threaded mailsMarkus Heidelberg, Jun 8, 2009
  36. 5/6 send-email: fix non-threaded mailsMarkus Heidelberg, Jun 7, 2009
  37. 5/6 send-email: fix non-threaded mailsMarkus Heidelberg, Jun 8, 2009
  38. 6/6 doc/send-email: clarify the behavior of --in-reply-to with --no-threadMarkus Heidelberg, Jun 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.