From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Thu, 11 Jun 2009 16:49:39 GMT
Subject: Re: [RF sanity check] send-email threading fixes (was Re: [PATCH 3/6] send-email: fix threaded mails without chain-reply-to)
Message-ID: <200906111849.40232.markus.heidelberg@web.de>
In-Reply-To: <7v63f4v9sl.fsf@alter.siamese.dyndns.org>

Junio C Hamano, 10.06.2009:
> In any case, here is what I came up with by reshuffling your six patches.
> 
> [PATCH 1/6] add a test for git-send-email for non-threaded mails
> [PATCH 2/6] send-email: fix non-threaded mails
> [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread
> [PATCH 4/6] send-email: fix threaded mails without chain-reply-to
> [PATCH 5/6] add a test for git-send-email for threaded mails without chain-reply-to
> [PATCH 6/6] send-email: fix a typo in a comment
> 
> Patch 4/6 applies on top of 15da108 to fix a breakage introduced by that
> commit.  Together with the result of applying the first three patches to
> maint, they fix --no-thread and --thread (without --chain-reply-to) cases.
> The result can be verified by applying Patch 5/6 on top of them.

Out of curiosity: why are 4/6 and 5/6 applied on different branches
without the usual commits first "test with test_expect_fail" then "fix +
test changed to test_expect_success"?