Re: [RF sanity check] send-email threading fixes

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 11, 2009, 20:38 UTC
Message-ID: <7vprdah5es.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200906111849.40232.markus.heidelberg@web.de>

Markus Heidelberg <markus.heidelberg@web.de> writes:

Show 12 quoted lines

>> [PATCH 4/6] send-email: fix threaded mails without chain-reply-to
>> [PATCH 5/6] add a test for git-send-email for threaded mails without chain-reply-to
>> [PATCH 6/6] send-email: fix a typo in a comment
>> 
>> Patch 4/6 applies on top of 15da108 to fix a breakage introduced by that
>> commit.  Together with the result of applying the first three patches to
>> maint, they fix --no-thread and --thread (without --chain-reply-to) cases.
>> The result can be verified by applying Patch 5/6 on top of them.
>
> Out of curiosity: why are 4/6 and 5/6 applied on different branches
> without the usual commits first "test with test_expect_fail" then "fix +
> test changed to test_expect_success"?

Maybe I misunderstood your problem description, but my impression from it was that 4/6 is a fix to a latent bug in 15da108 that later affected what was done by new code that appeard somewhere between 15da108 and 'master', and the test 5/6 was about that breakage. IOW, root cause was older than the symptom.