Re: [PATCH v2 4/6] add a test for git-send-email for non-threaded mails

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2009, 07:00 UTC
Message-ID: <7vd49f8b1f.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200906080842.00357.markus.heidelberg@web.de>

Markus Heidelberg <markus.heidelberg@web.de> writes:

Show 8 quoted lines

> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>
> Differences to v1:
> * dump stdout into a file and grep this
> * use "test_must_fail grep" instead of "!git send-email"
>   I'm not sure about this. When should test_must_fail be used and when
>   is !command OK?

Thanks.

Generally, we protect "git" (i.e. what we write ourselves) with test_must_fail so that we can catch stupid segfaulting crash we introduce ourselves (unlike "! git foo", "test_must_fail git foo" says "oh, no, it did not correctly fail" if git segfaults). We do not expect "grep" to segfault (iow we are not testing "grep"), so it is customary to say "! grep".