Re: PUSH_HEAD, was Re: disallowing push to currently checked-out branch

From: Jeff King <peff@peff.net>
Date: Feb 17, 2009, 19:48 UTC
Message-ID: <20090217194827.GB16067@coredump.intra.peff.net>
In-Reply-To: <76718490902170929v3ed9e3c2tb2f7fb1bfc01b3ab@mail.gmail.com>

On Tue, Feb 17, 2009 at 12:29:53PM -0500, Jay Soffian wrote:

Show 5 quoted lines

> So both you and Junio have changed your mind since that thread then.
> Because in that thread, you propose  receive.guardCurrentBranch, which
> was quite similar to today's receive.denyCurrentBranch. Junio then
> argues that treating just the checked-out branch as special, as
> opposed to all local branches is not the right thing to do:

I have to admit, I found that thread a very interesting read, because I somehow missed it the first time and it seemed the opposite of what happened later.

> So, I'm not sure what happened in the intervening time between the
> receive.localBranches proposal and the receive.denyCurrentBranch
> implementation that suddenly what is basically guardCurrentBranch
> became a good idea.

I think what happened (partially) is that I never read the original, then at GitTogether somebody (Sam?) was complaining about usability issues, so I wrote the denyCurrentBranch patch. Why and how people changed their minds is a mystery to me, though.

-Peff

PS I seem to have an uncanny knack for writing a patch, then finding out that Dscho wrote the exact same patch months or years earlier. I think this is the third time it has happened.