From: Shawn O. Pearce Date: Wed, 11 Feb 2009 16:24:32 GMT Subject: Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention Message-ID: <20090211162432.GF30949@spearce.org> In-Reply-To: <1234366634-17900-3-git-send-email-ted@tedpavlic.com> Ted Pavlic wrote: > In the single case of: > > if [...] || [...] > > changed to: > > if test ... || test ... NAK. This script only runs in bash. bash supports [...]. The prevailing convention in the script is to use [...]. Only 4 tests inside of __git_ps1 use "test", the rest of the code is using [...]. I would agree to a test->[...] conversion patch as its fairly small, but not this one. Too large, too much code churn, no benefit. -- Shawn.