Re: [PATCH] Switch receive.denyCurrentBranch to "refuse"
- From
Jeff King <peff@peff.net>
- Date
- Jan 30, 2009, 02:55 UTC
- Message-ID
- <20090130025546.GA18257@coredump.intra.peff.net>
- In-Reply-To
- <alpine.DEB.1.00.0901300133070.3586@pacific.mpi-cbg.de>
On Fri, Jan 30, 2009 at 01:34:28AM +0100, Johannes Schindelin wrote:
Show 5 quoted lines
> Let's be honest here, I have not much respect for users who fail > to read up enough to understand what they are doing. > > But hearing from those users constantly is really unnerving. And > it would be a one-time cost to old-timers.
I am not personally opposed to changing this default. I seem to recall some opposition when this was brought up initially, but I don't recall any specific reason besides "change is bad". Maybe those who oppose want to summarize their arguments here.
I was hoping that introducing the warning would cause new users to "get it". But since this warning was put in place, I think we have still gotten a few questions on the list about this. I don't know if it simply because they are on older versions, or if the warning is insufficient. If the former, then perhaps that argues for leaving it a little longer.
> case DENY_REFUSE: > - if (!is_ref_checked_out(name)) > + if (is_bare_repository() || !is_ref_checked_out(name))
Now what is this change about?
Show 11 quoted lines
> --- a/t/t5701-clone-local.sh > +++ b/t/t5701-clone-local.sh > @@ -119,7 +119,7 @@ test_expect_success 'bundle clone with nonexistent HEAD' ' > test_expect_success 'clone empty repository' ' > cd "$D" && > mkdir empty && > - (cd empty && git init) && > + (cd empty && git init && git config receive.denyCurrentBranch false) && > git clone empty empty-clone && > test_tick && > (cd empty-clone
Perhaps some of these tests would do better to actually just use a bare repository. That would better match the expected workflow for cloning empty, anyway.
-Peff