Re: [PATCH] prepare deprecation of git-revert

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 31, 2008, 23:24 UTC
Message-ID: <20081031232419.GA21997@steel.home>
In-Reply-To: <20081031165814.GD627@artemis.corp>

Pierre Habouzit, Fri, Oct 31, 2008 17:58:14 +0100:

Show 15 quoted lines

> On Fri, Oct 31, 2008 at 04:50:03PM +0000, Alex Riesen wrote:
> > Pierre Habouzit, Fri, Oct 31, 2008 16:55:27 +0100:
> > > @@ -439,16 +436,17 @@ static int revert_or_cherry_pick(int argc, const char **argv)
> > >  
> > >  int cmd_revert(int argc, const char **argv, const char *prefix)
> > >  {
> > > +#if 0
> > > +	warning("git revert is deprecated, please use git cherry-pick --revert/-R instead");
> > > +#endif
> > 
> > "git revert" is much shorter to type than "git cherry-pick -R".
> > How about renaming "cherry-pick" into something short, like "pick"?
> 
> Do you really use git revert _that_ often ? I don't. And cherry-pick is
> a really usual name for the tool.

Have it 5 times in my bash history of 20k lines. 4 recent, one relatively old.

> FWIW the basic idea is to deprecate revert in a (not so ?) long time,
> and leave git revert unimplemented for ever so that people that would
> like it to be 'git checkout HEAD --' alias it to that, and the ones that
> want to keep the current behaviour alias it to 'git cherry-pick -R'

Well, I kind of got used to it. And it makes sense (as does -R by cherry-pick, I have to admit). I have no other argument against the change.