git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration

From
Jeff King <peff@peff.net>
Date
Sep 3, 2008, 21:04 UTC
Message-ID
<20080903210418.GB32413@coredump.intra.peff.net>
In-Reply-To
<7vsksh9c9m.fsf@gitster.siamese.dyndns.org>
On Wed, Sep 03, 2008 at 01:59:17PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> > Isn't that what you argued against in Dscho's version of the patch?
> >
> >     http://mid.gmane.org/7v1w5exfwb.fsf@gitster.siamese.dyndns.org
> 
> Yeah, but unlike Linus, I am not infallible.  Also, I can change my mind.

Heh. OK, I am not against you changing your mind, but I like to at least see "...and here is what is different." So thank you.

I think adding the space to the parentheses makes the most sense. Without more advanced syntax, we have to make a choice between doing too much (e.g., adding parentheses when the user doesn't want it) and too little (the user has to put in parentheses manually, which means they are there whether there is decoration or not). Doing parentheses _without_ the space means we fail at both. So let us at least get it half right. ;)

-Peff
Previous: Junio C HamanoNext: René Scharfe
Message 6 of 23 in “add '%d' pretty format specifier to show decoration”
  1. 1/2 add '%d' pretty format specifier to show decorationMichael Dressel, Sep 3, 2008
  2. Jeff KingSep 3, 2008
  3. Junio C HamanoSep 3, 2008
  4. Jeff KingSep 3, 2008
  5. Junio C HamanoSep 3, 2008
  6. Jeff KingSep 3, 2008
  7. René ScharfeSep 3, 2008
  8. Jeff KingSep 4, 2008
  9. René ScharfeSep 4, 2008
  10. 1/3 log: add load_ref_decorations()René Scharfe, Sep 4, 2008
  11. 2/3 move load_ref_decorations() to log-tree.c and export itRené Scharfe, Sep 4, 2008
  12. 3/3 add '%d' pretty format specifier to show decorationRené Scharfe, Sep 4, 2008
  13. Jeff KingSep 5, 2008
  14. Junio C HamanoSep 5, 2008
  15. Jeff KingSep 5, 2008
  16. Junio C HamanoSep 5, 2008
  17. Michael DresselSep 5, 2008
  18. Michael DresselSep 9, 2008
  19. René ScharfeSep 9, 2008
  20. René ScharfeSep 5, 2008
  21. Jeff KingSep 3, 2008
  22. Michael DresselSep 3, 2008
  23. Jeff KingSep 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.