git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration

From
Jeff King <peff@peff.net>
Date
Sep 3, 2008, 20:33 UTC
Message-ID
<20080903203324.GA32223@coredump.intra.peff.net>
In-Reply-To
<alpine.LNX.1.10.0809032200490.32548@pollux>
On Wed, Sep 03, 2008 at 10:06:45PM +0200, Michael Dressel wrote:
Show 5 quoted lines
> I'm sorry for not properly citing you. I did mention you in the commit
> message which is wrong. So what would be the right way? Just adding a
> line Signed-off-by: Jeff King <peff@peff.net>
> before the ---?
> Or resending your original patch and than my patch on top of yours?

Oh, you cited me just fine. The Signed-off-by line isn't for credit; it indicates that you agree to the Developer's Certificate of Origin. IOW, it says "I wrote this (or I know who did) and I know it can be licensed for the project". So what I was saying was not "oh, you didn't credit me properly" but rather "you may also add to the official record that the parts I wrote are fine to be GPL'd for the project."

So in this case, I would simply add my Signed-off-by to the commit message when you resend the patch.

-Peff
Previous: Michael Dressel
Message 23 of 23 in “add '%d' pretty format specifier to show decoration”
  1. 1/2 add '%d' pretty format specifier to show decorationMichael Dressel, Sep 3, 2008
  2. Jeff KingSep 3, 2008
  3. Junio C HamanoSep 3, 2008
  4. Jeff KingSep 3, 2008
  5. Junio C HamanoSep 3, 2008
  6. Jeff KingSep 3, 2008
  7. René ScharfeSep 3, 2008
  8. Jeff KingSep 4, 2008
  9. René ScharfeSep 4, 2008
  10. 1/3 log: add load_ref_decorations()René Scharfe, Sep 4, 2008
  11. 2/3 move load_ref_decorations() to log-tree.c and export itRené Scharfe, Sep 4, 2008
  12. 3/3 add '%d' pretty format specifier to show decorationRené Scharfe, Sep 4, 2008
  13. Jeff KingSep 5, 2008
  14. Junio C HamanoSep 5, 2008
  15. Jeff KingSep 5, 2008
  16. Junio C HamanoSep 5, 2008
  17. Michael DresselSep 5, 2008
  18. Michael DresselSep 9, 2008
  19. René ScharfeSep 9, 2008
  20. René ScharfeSep 5, 2008
  21. Jeff KingSep 3, 2008
  22. Michael DresselSep 3, 2008
  23. Jeff KingSep 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.