git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Sep 4, 2008, 15:47 UTC
Message-ID
<48C002FB.9010401@lsrfire.ath.cx>
In-Reply-To
<20080904035139.GA28123@sigill.intra.peff.net>
Jeff King schrieb:
Show 12 quoted lines
> On Thu, Sep 04, 2008 at 12:06:18AM +0200, René Scharfe wrote:
>> +	case 'd':
>> +		if (add_again(sb, &c->decoration))
>> +			return 1;
>> +		format_decoration(sb, commit);
>> +		c->decoration.len = sb->len - c->decoration.off;
>> +		return 1;
> 
> The add_again chunk code is for things that take a long time (like
> finding the shortest abbreviation for some hashes). I'm not sure this
> counts as "long", as it is just doing a hash lookup on the decoration.
> On the other hand, I doubt the extra couple of bytes used hurts much.

Yes, you're right -- let's do without caching at first. If it turns out that we're too slow we can easily add it later.

Thanks, René

Previous: Jeff KingNext: René Scharfe
Message 9 of 23 in “add '%d' pretty format specifier to show decoration”
  1. 1/2 add '%d' pretty format specifier to show decorationMichael Dressel, Sep 3, 2008
  2. Jeff KingSep 3, 2008
  3. Junio C HamanoSep 3, 2008
  4. Jeff KingSep 3, 2008
  5. Junio C HamanoSep 3, 2008
  6. Jeff KingSep 3, 2008
  7. René ScharfeSep 3, 2008
  8. Jeff KingSep 4, 2008
  9. René ScharfeSep 4, 2008
  10. 1/3 log: add load_ref_decorations()René Scharfe, Sep 4, 2008
  11. 2/3 move load_ref_decorations() to log-tree.c and export itRené Scharfe, Sep 4, 2008
  12. 3/3 add '%d' pretty format specifier to show decorationRené Scharfe, Sep 4, 2008
  13. Jeff KingSep 5, 2008
  14. Junio C HamanoSep 5, 2008
  15. Jeff KingSep 5, 2008
  16. Junio C HamanoSep 5, 2008
  17. Michael DresselSep 5, 2008
  18. Michael DresselSep 9, 2008
  19. René ScharfeSep 9, 2008
  20. René ScharfeSep 5, 2008
  21. Jeff KingSep 3, 2008
  22. Michael DresselSep 3, 2008
  23. Jeff KingSep 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.