From: Jeff King <peff@peff.net>
Date: Wed, 03 Sep 2008 21:04:18 GMT
Subject: Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration
Message-ID: <20080903210418.GB32413@coredump.intra.peff.net>
In-Reply-To: <7vsksh9c9m.fsf@gitster.siamese.dyndns.org>

On Wed, Sep 03, 2008 at 01:59:17PM -0700, Junio C Hamano wrote:

> > Isn't that what you argued against in Dscho's version of the patch?
> >
> >     http://mid.gmane.org/7v1w5exfwb.fsf@gitster.siamese.dyndns.org
> 
> Yeah, but unlike Linus, I am not infallible.  Also, I can change my mind.

Heh. OK, I am not against you changing your mind, but I like to at least
see "...and here is what is different." So thank you.

I think adding the space to the parentheses makes the most sense.
Without more advanced syntax, we have to make a choice between doing too
much (e.g., adding parentheses when the user doesn't want it) and too
little (the user has to put in parentheses manually, which means they
are there whether there is decoration or not). Doing parentheses
_without_ the space means we fail at both. So let us at least get it
half right. ;)

-Peff