From: Jeff King <peff@peff.net>
Date: Wed, 03 Sep 2008 20:33:24 GMT
Subject: Re: [PATCH 1/2] add '%d' pretty format specifier to show decoration
Message-ID: <20080903203324.GA32223@coredump.intra.peff.net>
In-Reply-To: <alpine.LNX.1.10.0809032200490.32548@pollux>

On Wed, Sep 03, 2008 at 10:06:45PM +0200, Michael Dressel wrote:

> I'm sorry for not properly citing you. I did mention you in the commit
> message which is wrong. So what would be the right way? Just adding a
> line Signed-off-by: Jeff King <peff@peff.net>
> before the ---?
> Or resending your original patch and than my patch on top of yours?

Oh, you cited me just fine. The Signed-off-by line isn't for credit; it
indicates that you agree to the Developer's Certificate of Origin. IOW,
it says "I wrote this (or I know who did) and I know it can be licensed
for the project". So what I was saying was not "oh, you didn't credit me
properly" but rather "you may also add to the official record that the
parts I wrote are fine to be GPL'd for the project."

So in this case, I would simply add my Signed-off-by to the commit
message when you resend the patch.

-Peff