Re: [PATCH v2] allow user aliases for the --author parameter
- From
Jeff King <peff@peff.net>
- Date
- Aug 27, 2008, 17:18 UTC
- Message-ID
- <20080827171846.GA14300@coredump.intra.peff.net>
- In-Reply-To
- <7vmyiyqt08.fsf@gitster.siamese.dyndns.org>
On Wed, Aug 27, 2008 at 10:15:19AM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> > I wonder if there is a good way to warn that we have multiple matches. > > Of course we expect many _exact_ matches if the author has multiple > > commits, but we could look for distinct matches. However, even that will > > turn up false positives, since some authors have multiple email > > addresses. > > In order to prove unique match you would need an exhaustive check, don't > you?
Yes, though you also do exhaustive check in the worst case already (when the name doesn't match anything). It takes about .7s on a warm cache on my git.git.
Anyway, I think it is already not a good idea because of the semantics, let alone the performance.
-Peff
PS Your message also didn't go to git@vger, so I think you are having the same problem with Michael's message that I am.