Re: [PATCH v2] allow user aliases for the --author parameter
- From
Jeff King <peff@peff.net>
- Date
- Aug 27, 2008, 00:19 UTC
- Message-ID
- <20080827001944.GA7347@coredump.intra.peff.net>
- In-Reply-To
- <7vsksr1hgt.fsf@gitster.siamese.dyndns.org>
On Tue, Aug 26, 2008 at 04:31:30PM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> > This allows the use of author abbreviations when specifying commit > > authors via the --author option to git commit. "--author=$key" is > > resolved by looking up "user.$key.name" and "user.$key.email" in the > > config. > > Maybe it is just me, but I am hesitant about the contamination of user.* > configuration namespace. This patch as a general solution does not scale > well, once you start working with more than a few dozen people.
It is not just you. I think this version of the patch is much improved, but I am still against user.$key.*. At the very least, it needs its own namespace.
I think if somebody cares, reading external files of various formats would be nice (and a simple "alias, space, expansion, newline" format could be introduced), but since I am not volunteering to implement that, this even simpler implementation is acceptable to me, as long as it is user.alias.$key.* or similar.
-Peff