Re: [PATCH v2] allow user aliases for the --author parameter

From: Jeff King <peff@peff.net>
Date: Aug 27, 2008, 12:29 UTC
Message-ID: <20080827122954.GA11986@coredump.intra.peff.net>
In-Reply-To: <7v7ia3rnnq.fsf@gitster.siamese.dyndns.org>

On Tue, Aug 26, 2008 at 11:13:13PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> > It is not just you. I think this version of the patch is much improved,
> > but I am still against user.$key.*. At the very least, it needs its own
> > namespace.
> 
> It's not just that.  Having many of these in .git/config will slow down
> any unrelated thing that needs to read from config.

Sure, it can, but so can putting a lot of branch info in your config. My thinking was that this covers the "I just want to put in a few entries easily" use case. If somebody wants to do something _big_, then that is time for the external format.

But then we have two formats which we must support forever, which is maybe a bad thing.

> I am not married to the "reuse existing information" idea, but doing it
> the way this sample patch does at least makes only people who uses this
> feature to pay the price and only when they use it.

Actually, I like this quite a bit. Almost by definition, the information is already here (and if it isn't, it is because it is the first time this person is an author, so you would have to end up typing it once _anyway_).

My only complaint is:

> +	strbuf_addf(&buf, "--author=%s", name);
> +	av[++ac] = "--all";
> +	av[++ac] = buf.buf;
> +	av[++ac] = NULL;

I am too lazy to hit "shift", so I would use "-i".

-Peff