Re: [PATCH] fix "git log -i --grep"
- From
Jeff King <peff@peff.net>
- Date
- Aug 25, 2008, 06:18 UTC
- Message-ID
- <20080825061833.GB9313@coredump.intra.peff.net>
- In-Reply-To
- <20080825061504.GA9313@coredump.intra.peff.net>
On Mon, Aug 25, 2008 at 02:15:05AM -0400, Jeff King wrote:
Show 7 quoted lines
> > As you suggested, making the grep option structure embedded in rev_info > > may not be a bad idea. We used to keep track of the sub-options > > separately while we encounter, and updated grep_filter at the end of the > > loop, but the conversion to use parse-options broke it. > > I worked up this patch, and it is below. However, I think it may not be > a good idea, because...
Actually, let me amend that. While writing the email, I came to the conclusion that the "complain if -i but not --grep" is probably not a good idea. So in that case, I think this patch (allocating grep_filter inside the struct) _is_ a good idea.
But I don't feel too strongly either way. If you disagree, we can go with the first one, and I can resend it (with the cleanup I mentioned) and I can do the trivial complaining patch on top of it.
-Peff