From: Jeff King <peff@peff.net>
Date: Thu, 31 Jul 2008 05:52:29 GMT
Subject: Re: [PATCH] format-patch: Produce better output with --inline or --attach
Message-ID: <20080731055229.GB17652@sigill.intra.peff.net>
In-Reply-To: <B805BDA1-6C22-4488-B5F5-6DA8CC729C06@sb.org>

On Wed, Jul 30, 2008 at 11:30:32AM -0700, Kevin Ballard wrote:

>>> The second change is to always write the line termination character
>>> (default: newline) even when using --inline or --attach. This is  
>> It appears that your patch has one uncontroversial and one  
>> controversial
>> part, then.
> Is this controversial? Nobody's objected so far. My goal with this change 
> is to make the --inline output render exactly the same as the default 
> output in a mail client. I can't think of any downside.

No. I didn't comment on it in my earlier response because I don't really
care. But I certainly have no problem with it, and it is probably an
improvement.

-Peff