git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-imap-send: Add support for SSL.

From
Jeff King <peff@peff.net>
Date
Jul 10, 2008, 06:39 UTC
Message-ID
<20080710063941.GC3195@sigill.intra.peff.net>
In-Reply-To
<1096648c0807091424g1e10d0ccrae0be929ec428b89@mail.gmail.com>
On Wed, Jul 09, 2008 at 10:24:27PM +0100, Rob Shearman wrote:
Show 10 quoted lines
> >>  [imap]
> >> +    sslverify = false
> > [...]
> >> +     else if (!strcmp( "ssl_verify", key ))
> >
> > The example and the code disagree on the name of the
> > sslverify/ssl_verify option.
> 
> I wouldn't exactly call it "disagree". The config variable is limited
> by not allowing underscores, whereas the C language does allow them.

I think his point is that the example says "sslverify" but the code is looking for the config variable "ssl_verify". So that config won't work.

However as you mention, underscore isn't allowed, so your strcmp line is totally bogus anyway, but you silently fix it in your 3/4 "style" fix.

-Peff
Previous: Rob Shearman
Message 8 of 8 in “git-imap-send: Add support for SSL.”
  1. 2/4 git-imap-send: Add support for SSL.Robert Shearman, Jul 8, 2008
  2. Junio C HamanoJul 8, 2008
  3. Abhijit Menon-SenJul 9, 2008
  4. Rob ShearmanJul 9, 2008
  5. Junio C HamanoJul 9, 2008
  6. Josh TriplettJul 9, 2008
  7. Rob ShearmanJul 9, 2008
  8. Jeff KingJul 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.