Re: [PATCH 2/4] git-imap-send: Add support for SSL.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 8, 2008, 23:20 UTC
Message-ID: <7vbq18q7yk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1215555496-21335-2-git-send-email-robertshearman@gmail.com>

Robert Shearman <robertshearman@gmail.com> writes:

Show 5 quoted lines

> Allow SSL to be used when a imaps:// URL is used for the host name.
>
> Also, automatically use TLS when not using imaps:// by using the IMAP STARTTLS command, if the server supports it.
>
> Tested with Courier and Gimap IMAP servers.

Sign-off?

Show 16 quoted lines

> diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt
> index b3d8da3..e4a5873 100644
> --- a/Documentation/git-imap-send.txt
> +++ b/Documentation/git-imap-send.txt
> @@ -37,10 +37,11 @@ configuration file (shown with examples):
>      Tunnel = "ssh -q user@server.com /usr/bin/imapd ./Maildir 2> /dev/null"
>  
>  [imap]
> -    Host = imap.server.com
> +    Host = imaps://imap.example.com
>      User = bob
>      Pass = pwd
> -    Port = 143
> +    Port = 993
> +    sslverify = false
>  ..........................

Don't we also want to keep a vanilla configuration in the example, or is imaps the norm and unencrypted imap is exception these days?

Don't we need to support custom certificates, keys and CAs, just like our code that supports https does, by honoring GIT_SSL_* environment variables and configuration file entries? The patch itself looks fairly clean, and I'd like to queue this for wider testing, initially even without GIT_SSL_* support. But I'd like to see any patch with substantial amount of changes properly signed off.

Thanks.