Re: [PATCH 2/4] git-imap-send: Add support for SSL.

From: Josh Triplett <josht@linux.vnet.ibm.com>
Date: Jul 9, 2008, 15:14 UTC
Message-ID: <1215616484.3053.6.camel@josh-work.beaverton.ibm.com>
In-Reply-To: <1215555496-21335-2-git-send-email-robertshearman@gmail.com>

On Tue, 2008-07-08 at 23:18 +0100, Robert Shearman wrote:

Show 13 quoted lines

> --- a/Documentation/git-imap-send.txt
> +++ b/Documentation/git-imap-send.txt
> @@ -37,10 +37,11 @@ configuration file (shown with examples):
>      Tunnel = "ssh -q user@server.com /usr/bin/imapd ./Maildir 2> /dev/null"
>  
>  [imap]
> -    Host = imap.server.com
> +    Host = imaps://imap.example.com
>      User = bob
>      Pass = pwd
> -    Port = 143
> +    Port = 993
> +    sslverify = false

[...]

Show 6 quoted lines

> @@ -1280,6 +1411,8 @@ git_imap_config(const char *key, const char *val, void *cb)
>  		server.port = git_config_int( key, val );
>  	else if (!strcmp( "tunnel", key ))
>  		server.tunnel = xstrdup( val );
> +	else if (!strcmp( "ssl_verify", key ))
> +		server.ssl_verify = git_config_bool( key, val );

The example and the code disagree on the name of the sslverify/ssl_verify option. Also, ssl_verify needs explanation.

- Josh Triplett